Skip to content

CPP Transformer Tutorial #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2020
Merged

CPP Transformer Tutorial #1192

merged 4 commits into from
Oct 27, 2020

Conversation

hlahkar
Copy link
Contributor

@hlahkar hlahkar commented Oct 19, 2020

This is Transformer example using CPP frontend

@netlify
Copy link

netlify bot commented Oct 19, 2020 •
edited
Loading

Deploy preview for pytorch-tutorials-preview failed.

Built with commit 95e40d9

https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/5f9829016e3c1400073022b2

@glaringlee glaringlee self-requested a review October 22, 2020 19:23
glaringlee
glaringlee reviewed Oct 22, 2020
View reviewed changes
Copy link
Contributor

@glaringlee glaringlee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing this tutorial. I have a nit comment at the end to avoid lint error. Will approve once this is corrected. Pleases rebase the code as well.

Not required for this PR. It would be great if you can write a .rst file to go over this example, since .rst file will be available on https://pytorch.org/tutorials/ as a text tutorial.

for example: https://github.com/pytorch/tutorials/blob/master/advanced_source/rpc_ddp_tutorial.rst

advanced_source/transformer__timeseries_cpp_tutorial/transformer_timeseries.cpp Outdated
evaluate(model, std::get<1>(data));

return 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add a new line here to avoid lint error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added the newline at the end

@hlahkar
Copy link
Contributor Author

hlahkar commented Oct 23, 2020

Thanks a lot for contributing this tutorial. I have a nit comment at the end to avoid lint error. Will approve once this is corrected. Pleases rebase the code as well.

Not required for this PR. It would be great if you can write a .rst file to go over this example, since .rst file will be available on https://pytorch.org/tutorials/ as a text tutorial.

for example: https://github.com/pytorch/tutorials/blob/master/advanced_source/rpc_ddp_tutorial.rst

Sure I will be raising a new PR for the .rst file

glaringlee
glaringlee approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@glaringlee glaringlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianjo brianjo merged commit 5c7e38b into pytorch:master Oct 27, 2020
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
@hlahkar @glaringlee @brianjo
CPP Transformer Tutorial (pytorch#1192)
10ab6e0 
Co-authored-by: xyli <32228059+glaringlee@users.noreply.github.com>
Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaringlee glaringlee glaringlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hlahkar @glaringlee @brianjo